tensorflow: add tf.distribute.experimental.coordinator.RemoteValue
#11349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
hoel-bagard
changed the title
tensorflow: add tf.distribute.experimental.coordinator.RemoteValue
hoel-bagard
force-pushed
the
hoel/add_distribute.experimental.coordinator
branch
from
3bed77d to
b6ae7c9
Compare
This comment has been minimized.
This comment has been minimized.
hoel-bagard
force-pushed
the
hoel/add_distribute.experimental.coordinator
branch
from
b07ed76 to
e51face
Compare
|
@hmc-cs-mdrissi This PR is getting the following import error, but I don't understand why: Probably unrelated, but in a previous PR I had to make this commit to change an import in order for CI to pass. I understand that TensorFlow's imports are a bit cursed, but I was a bit surprised to have to do that in the stubs. |
hoel-bagard
force-pushed
the
hoel/add_distribute.experimental.coordinator
branch
from
0a7fece to
e51face
Compare
This comment has been minimized.
This comment has been minimized.
is a similar example. For some documented types importing it from module vs accessing it by attribute so,
from tensorflow.distribute.experimental.coordinator import RemoveValuevs import tensorflow as tf
tf.distribute.experimental.coordinator.RemoteValueone works, other crashes. I don't know any way to describe this behavior in stubs. It's undocumented behavior and side effect of weird import magic tensorflow does. Maybe future version/issue will fix this and make both ways work. I recommend stubtest allowlist with a comment of |
This comment has been minimized.
This comment has been minimized.
hmc-cs-mdrissi
approved these changes
Feb 5, 2024
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class is only available in
tensorflow>=2.15(cf documentation).